(8.4)PS-11216: Timestamps needed in the GCS_DEBUG_TRACE file#6050
(8.4)PS-11216: Timestamps needed in the GCS_DEBUG_TRACE file#6050jaideepkarande wants to merge 1 commit into
Conversation
jaideepkarande
changed the title
|
https://ps80.cd.percona.com/job/percona-server-8.4-pipeline-parallel-mtr/1279/consoleFull |
76437b5 to
63a717e
Compare
Every line written to GCS_DEBUG_TRACE now carries an ISO 8601 UTC timestamp with microsecond precision at the front of the line: [YYYY-MM-DDTHH:MM:SS.uuuuuuZ] [MYSQL_GCS_DEBUG] [GCS] <message>
63a717e to
35823af
Compare
|
https://ps80.cd.percona.com/job/percona-server-8.4-pipeline-parallel-mtr/1281/consoleFull main.all_persisted_variables failed -include/assert.inc [Expect 490 persisted variables in the table.] Failing test case shows extra persisted variable not related to the code changes. |
kamil-holubicki
left a comment
kamil-holubicki
left a comment
There was a problem hiding this comment.
Please consider comments about cosmetic things
|
|
||
| /** | ||
| Add extra information as a message prefix. | ||
| [YYYY-MM-DDTHH:MM:SS.uuuuuuZ] [MYSQL_GCS_DEBUG] [GCS] <message> |
There was a problem hiding this comment.
Claude:
Header docstring inconsistency. gcs_logging_system.h:661 — the format example is dropped into the Doxygen brief without any
@code/formatting; brackets can trip Doxygen. Prefer:
/**
Format: [YYYY-MM-DDTHH:MM:SS.uuuuuuZ] [MYSQL_GCS_DEBUG] [GCS]
| ################################################################################ | ||
| # PS-11216: Timestamps needed in the GCS_DEBUG_TRACE file | ||
| # | ||
| # This test case veritfy that every log written to GCS_DEBUG_TRACE carries a |
| const long usec = static_cast<long>(us % 1000000); | ||
| struct tm tm_info; | ||
| if (gmtime_r(&sec, &tm_info) == nullptr) return 0; | ||
| int len = sprintf(buf, "[%04d-%02d-%02dT%02d:%02d:%02d.%06ldZ] ", |
There was a problem hiding this comment.
It is not critical, as it is constant string by format, but suggestion:
sprintf → snprintf(buf, 32, …)
2 participants
Every line written to GCS_DEBUG_TRACE now carries an ISO 8601 UTC timestamp with microsecond precision at the front of the line:
[YYYY-MM-DDTHH:MM:SS.uuuuuuZ] [MYSQL_GCS_DEBUG] [GCS]